Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make #[system_param(ignore)] and #[world_query(ignore)] unnecessary #8030

Merged
merged 42 commits into from
Mar 30, 2023
Merged

Make #[system_param(ignore)] and #[world_query(ignore)] unnecessary #8030

merged 42 commits into from
Mar 30, 2023

Commits on Mar 10, 2023

  1. impl SystemParam for PhantomData

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    c766e7c View commit details
    Browse the repository at this point in the history

  2. ensure state types don't collide for SystemParam

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    8994d13 View commit details
    Browse the repository at this point in the history

  3. add a dedicated method for generating identifiers with no collision

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    92d7921 View commit details
    Browse the repository at this point in the history

  4. add a comment describing the collision algorithm

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    1c6d01f View commit details
    Browse the repository at this point in the history

  5. use explicit lifetimes in the SystemParam derive

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    a25fb60 View commit details
    Browse the repository at this point in the history

  6. remove #system_param(ignore)

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    65f332e View commit details
    Browse the repository at this point in the history

  7. clean up state struct lifetimes

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    43507a6 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/main' into system-param-phanto… 

    …m-data
    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    6df2d0a View commit details
    Browse the repository at this point in the history

  9. remove unused attributes

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    4e5797c View commit details
    Browse the repository at this point in the history

  10. use a descriptive name for a macro variable

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    6eac07a View commit details
    Browse the repository at this point in the history

  11. implement WorldQuery for PhantomData

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    653fc46 View commit details
    Browse the repository at this point in the history

  12. add a compile test

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    e18e7af View commit details
    Browse the repository at this point in the history

  13. remove #[world_query(ignore)]

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    715f8ec View commit details
    Browse the repository at this point in the history

  14. make world_query(ignore) an error

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    f60909b View commit details
    Browse the repository at this point in the history

  15. add comments to IS_DENSE and IS_ARCHETYPAL

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    4ee9978 View commit details
    Browse the repository at this point in the history

  16. update a comment

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    3a55ca1 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2023

  1. disallow #[system_param] attributes

    @JoJoJet
    JoJoJet committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    c4005ac View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into system-param-phanto… 

    …m-data
    @JoJoJet
    JoJoJet committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    136033c View commit details
    Browse the repository at this point in the history

  3. remove an unused const

    @JoJoJet
    JoJoJet committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    eaddf9a View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. undo an overlapping change

    @JoJoJet
    JoJoJet committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    b2f4309 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. add an example demonstrating PhantomData queries

    @JoJoJet
    JoJoJet committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    0ab464c View commit details
    Browse the repository at this point in the history

  2. import worldquery

    @JoJoJet
    JoJoJet committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    978437a View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. remove collision code

    @JoJoJet
    JoJoJet committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    08d6b60 View commit details
    Browse the repository at this point in the history

  2. remove needless whitespace

    @JoJoJet
    JoJoJet committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    244a589 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into system-param-phanto… 

    …m-data
    @JoJoJet
    JoJoJet committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    6f5d446 View commit details
    Browse the repository at this point in the history

  4. remove an unused import

    @JoJoJet
    JoJoJet committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    3f0bd19 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Merge remote-tracking branch 'upstream/main' into system-param-phanto… 

    …m-data
    @JoJoJet
    JoJoJet committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    47040f2 View commit details
    Browse the repository at this point in the history

  2. fix formatting for a let ... else block

    @JoJoJet
    JoJoJet committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    988ec67 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Merge remote-tracking branch 'upstream/main' into system-param-phanto… 

    …m-data
    @JoJoJet
    JoJoJet committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    986f10c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into system-param-phanto… 

    …m-data
    @JoJoJet
    JoJoJet committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    aebb03d View commit details
    Browse the repository at this point in the history

  3. remove a space

    @JoJoJet
    JoJoJet committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    589361e View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. use non-conflicting lifetime names

    @JoJoJet
    JoJoJet committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    5dfc332 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. add a test case for invariant lifetimes

    @JoJoJet
    JoJoJet committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    93624c3 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. re-add #[system_param(ignore)]

    @JoJoJet
    JoJoJet committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    eb3e17d View commit details
    Browse the repository at this point in the history

  2. re-add #[world_query(ignore)]

    @JoJoJet
    JoJoJet committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    f3572b1 View commit details
    Browse the repository at this point in the history

  3. restore some docs

    @JoJoJet
    JoJoJet committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    bcfee71 View commit details
    Browse the repository at this point in the history

  4. cargo fmt

    @JoJoJet
    JoJoJet committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    10edef0 View commit details
    Browse the repository at this point in the history

  5. re-order an example

    @JoJoJet
    JoJoJet committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    f8469c5 View commit details
    Browse the repository at this point in the history

  6. allow unlimited ignored fields

    @JoJoJet
    JoJoJet committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    2579709 View commit details
    Browse the repository at this point in the history

  7. reduce churn

    @JoJoJet
    JoJoJet committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    6a3cfce View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Update crates/bevy_ecs/macros/src/lib.rs

    @JoJoJet
    JoJoJet authored Mar 29, 2023
    Configuration menu
    Copy the full SHA
    8ff0178 View commit details
    Browse the repository at this point in the history

  2. deduplicate regression tests

    @JoJoJet
    JoJoJet committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    464e095 View commit details
    Browse the repository at this point in the history