Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Remove .on_update method to improve API consistency and clarity #7667

Closed

Conversation

alice-i-cecile
Copy link
Member

Objective

Fixes #7632.

As discussed in #7634, it can be quite challenging for users to intuit the mental model of how states now work.

Solution

Rather than change the behavior of the OnUpdate system set, instead work on making sure it's easy to understand what's going on.

Two things have been done:

  1. Remove the .on_update method from our bevy of system building traits. This was special-cased and made states feel much more magical than they need to.
  2. Improve the docs for the OnUpdate system set.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Feb 13, 2023
@alice-i-cecile alice-i-cecile added this to the 0.10 milestone Feb 13, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 14, 2023
@alice-i-cecile
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Feb 14, 2023
# Objective

Fixes #7632.

As discussed in #7634, it can be quite challenging for users to intuit the mental model of how states now work.

## Solution

Rather than change the behavior of the `OnUpdate` system set, instead work on making sure it's easy to understand what's going on.

Two things have been done:

1. Remove the `.on_update` method from our bevy of system building traits. This was special-cased and made states feel much more magical than they need to.
2. Improve the docs for the `OnUpdate` system set.
@bors bors bot changed the title Remove .on_update method to improve API consistency and clarity [Merged by Bors] - Remove .on_update method to improve API consistency and clarity Feb 14, 2023
@bors bors bot closed this Feb 14, 2023
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 15, 2023
…engine#7667)

# Objective

Fixes bevyengine#7632.

As discussed in bevyengine#7634, it can be quite challenging for users to intuit the mental model of how states now work.

## Solution

Rather than change the behavior of the `OnUpdate` system set, instead work on making sure it's easy to understand what's going on.

Two things have been done:

1. Remove the `.on_update` method from our bevy of system building traits. This was special-cased and made states feel much more magical than they need to.
2. Improve the docs for the `OnUpdate` system set.
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 15, 2023
…engine#7667)

# Objective

Fixes bevyengine#7632.

As discussed in bevyengine#7634, it can be quite challenging for users to intuit the mental model of how states now work.

## Solution

Rather than change the behavior of the `OnUpdate` system set, instead work on making sure it's easy to understand what's going on.

Two things have been done:

1. Remove the `.on_update` method from our bevy of system building traits. This was special-cased and made states feel much more magical than they need to.
2. Improve the docs for the `OnUpdate` system set.
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 15, 2023
…engine#7667)

# Objective

Fixes bevyengine#7632.

As discussed in bevyengine#7634, it can be quite challenging for users to intuit the mental model of how states now work.

## Solution

Rather than change the behavior of the `OnUpdate` system set, instead work on making sure it's easy to understand what's going on.

Two things have been done:

1. Remove the `.on_update` method from our bevy of system building traits. This was special-cased and made states feel much more magical than they need to.
2. Improve the docs for the `OnUpdate` system set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected SystemInMultipleBaseSets panic due to on_update
3 participants