Use ValueInfo inside structs in bevy_reflect

[myreprise1]

Objective

• Make defining several structs in bevy_reflect less verbose by replacing certain fields with ValueInfo. Since these are private fields, no outward changes should be needed.

Solution

Replaced fields in the form:

struct FooInfo {
    bar_name: &'static str,
    bar_id: TypeId,
}

impl FooInfo {
    fn new<T: BarType>() -> Self {
        Self {
            bar_name: std::any::type_name::<T>(),
            bar_id: TypeId::of::<T>(),
        }
    }
}

With the following:

struct FooInfo {
    bar_value: ValueInfo,
}

impl FooInfo {
    fn new<T: BarType>() -> Self {
        Self {
            bar_value: ValueInfo::new::<T>(),
        }
    }
}

[MrGVSV]

Simpler, cleaner, DRYer. I don't see much reason not to do this (at least for now).

[MrGVSV]

Bikeshed: I think these names are fine, but here are some others to consider:

1. container_type, item_type, key_type, field_type, etc.
2. type_info, item_type_info, key_type_info, field_type_info, etc.

For me, I think I'd lean more towards either keeping what you have now or going with Alternative 1 (2 is okay, but has the implication that it contains a TypeInfo not a ValueInfo).

I’m curious if you or anyone else has any thoughts on this?

[myreprise1]

I just replaced name and id with value for consistency. I'm thinking maybe key_type_value and item_type_value.

[MrGVSV]

@myreprise1 this may need to be rebased