Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - implement Reflect for Fxaa #7527

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - implement Reflect for Fxaa #7527

wants to merge 2 commits into from

Conversation

jakobhellermann
Copy link
Contributor

Objective

  • public components and resources should implement Reflect if possible

Solution

  • derive Reflect

MrGVSV
MrGVSV reviewed Feb 6, 2023
View reviewed changes
crates/bevy_core_pipeline/src/fxaa/mod.rs Outdated Show resolved Hide resolved
crates/bevy_core_pipeline/src/fxaa/mod.rs Outdated Show resolved Hide resolved
crates/bevy_core_pipeline/src/fxaa/mod.rs Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Feb 6, 2023
@Elabajaba Elabajaba mentioned this pull request Feb 6, 2023
Merged
@MrGVSV MrGVSV added this to the 0.10 milestone Feb 13, 2023
@alice-i-cecile
Copy link
Member

Seconding the above requests.

@jakobhellermann
Copy link
Contributor Author

added the missing attributes

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 13, 2023
@jakobhellermann
implement Reflect for Fxaa (#7527)
17ed41d 
# Objective

- public components and resources should implement `Reflect` if possible

## Solution

- derive `Reflect`
@bors
Copy link
Contributor

bors bot commented Feb 13, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title implement Reflect for Fxaa [Merged by Bors] - implement Reflect for Fxaa Feb 13, 2023
@bors bors bot closed this Feb 13, 2023
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 14, 2023
@jakobhellermann @myreprise1
implement Reflect for Fxaa (bevyengine#7527)
0a7e8bd 
- public components and resources should implement `Reflect` if possible

- derive `Reflect`
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 15, 2023
@jakobhellermann @myreprise1
implement Reflect for Fxaa (bevyengine#7527)
ae23cf7 
- public components and resources should implement `Reflect` if possible

- derive `Reflect`
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 15, 2023
@jakobhellermann @myreprise1
implement Reflect for Fxaa (bevyengine#7527)
0c74b80 
- public components and resources should implement `Reflect` if possible

- derive `Reflect`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@MrGVSV MrGVSV MrGVSV approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
Reflection
Status: Done
Milestone
0.10
Development

Successfully merging this pull request may close these issues.
3 participants
@jakobhellermann @alice-i-cecile @MrGVSV