[Merged by Bors] - Add main_texture_other #7343
Conversation
Signed-off-by: Torstein Grindvik <[email protected]>
alice-i-cecile
added
A-Rendering
|
I'm confused on how this would work. During the prepare render stage, when creating bind groups, you won't know which texture will be the last written to, so you can't bind that as read. For instance, given nodes A -> B, if A does a post_process_write(), that affects which texture B will need to read from. How would B know which texture to bind? Maybe I'm missing something about this. |
|
@IceSentry agreed, I couldn't think of a good name either. @JMS55 Within the node I have a TextureViewId which I swap before the draw functions are called such that the correct bind group is bound. |
|
I see what you mean. I agree it fits your use case, but it's a very niche situation. I'll approve the PR, but I'd like the docs to indicate that it's probably not what you want 99% of the time. Name is fine imo, I can't think of anything better either. |
Signed-off-by: Torstein Grindvik <[email protected]>
|
@JMS55 I made the language in the docs even stronger to indicate that this method is only needed when you know you need it.
Yes I think so too. |
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
# Objective ## Use Case A render node which calls `post_process_write()` on a `ViewTarget` multiple times during a single run of the node means both main textures of this view target is accessed. If the source texture (which alternate between main textures **a** and **b**) is accessed in a shader during those iterations it means that those textures have to be bound using bind groups. Preparing bind groups for both main textures ahead of time is desired, which means having access to the _other_ main texture is needed. ## Solution Add a method on `ViewTarget` for accessing the other main texture. --- ## Changelog ### Added - `main_texture_other` API on `ViewTarget`
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
# Objective ## Use Case A render node which calls `post_process_write()` on a `ViewTarget` multiple times during a single run of the node means both main textures of this view target is accessed. If the source texture (which alternate between main textures **a** and **b**) is accessed in a shader during those iterations it means that those textures have to be bound using bind groups. Preparing bind groups for both main textures ahead of time is desired, which means having access to the _other_ main texture is needed. ## Solution Add a method on `ViewTarget` for accessing the other main texture. --- ## Changelog ### Added - `main_texture_other` API on `ViewTarget`
Objective
Use Case
A render node which calls
post_process_write()on aViewTargetmultiple times during a single run of the node means both main textures of this view target is accessed.If the source texture (which alternate between main textures a and b) is accessed in a shader during those iterations it means that those textures have to be bound using bind groups.
Preparing bind groups for both main textures ahead of time is desired, which means having access to the other main texture is needed.
Solution
Add a method on
ViewTargetfor accessing the other main texture.Changelog
Added
main_texture_otherAPI onViewTarget