[Merged by Bors] - Add context to compile tests #7342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoJoJet
added
A-ECS
james7132
approved these changes
Jan 23, 2023
james7132
added
the
S-Ready-For-Final-Review
bors bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
# Objective `bevy_ecs/system_param.rs` contains many seemingly-arbitrary struct definitions which serve as compile tests. ## Solution Add a comment to each one, linking the issue or PR that motivated its addition.
|
Timed out. |
mockersf
approved these changes
Jan 23, 2023
|
action timed out while retrieving cache |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
# Objective `bevy_ecs/system_param.rs` contains many seemingly-arbitrary struct definitions which serve as compile tests. ## Solution Add a comment to each one, linking the issue or PR that motivated its addition.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective `bevy_ecs/system_param.rs` contains many seemingly-arbitrary struct definitions which serve as compile tests. ## Solution Add a comment to each one, linking the issue or PR that motivated its addition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_ecs/system_param.rscontains many seemingly-arbitrary struct definitions which serve as compile tests.Solution
Add a comment to each one, linking the issue or PR that motivated its addition.