[Merged by Bors] - Rename dynamic feature #7340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CGMossa
reviewed
Jan 23, 2023
| @@ -2,7 +2,7 @@ | |||
| name = "bevy_internal" | |||
| version = "0.9.0" | |||
| edition = "2021" | |||
| description = "An internal Bevy crate used to facilitate optional dynamic linking via the 'dynamic' feature" | |||
| description = "An internal Bevy crate used to facilitate optional dynamic linking via the 'dynamic_linking' feature" | |||
There was a problem hiding this comment.
I'm not sure if cargo supports markdown for crate desc, could you give me an example?
CGMossa
approved these changes
Jan 23, 2023
alice-i-cecile
added
C-Usability
alice-i-cecile
approved these changes
Jan 23, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
# Objective - Fixes #7334 ## Solution - Rename `dynamic` feature to `dynamic_linking`. --- ## Migration Guide - `dynamic` feature was renamed to `dynamic_linking`
bors
bot
changed the title
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Fixes bevyengine#7334 ## Solution - Rename `dynamic` feature to `dynamic_linking`. --- ## Migration Guide - `dynamic` feature was renamed to `dynamic_linking`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
dynamicfeature a more explicit name likedynamic_linking? #7334Solution
dynamicfeature todynamic_linking.Migration Guide
dynamicfeature was renamed todynamic_linking