Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Make the many_foxes plane smaller to fix shadow issues. #7339

Closed
wants to merge 1 commit into from

Conversation

Elabajaba
Copy link
Contributor

Objective

Shadows are broken on many_foxes on AMD GPUs. This seems to be due to rounding or floating point precision issues combined with the absolute unit of a plane that it's currently using.

Related: #6542

I'm not sure if we want to close that issue, as there's still the underlying issue of shadows breaking on overly large planes.

Solution

Make the plane smaller.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels Jan 23, 2023
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection to this fix, but I'd like to keep the issue open.

@hymm hymm self-requested a review January 23, 2023 02:37
Copy link
Contributor

@djeedai djeedai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as @alice-i-cecile

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 23, 2023
@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 23, 2023
# Objective

Shadows are broken on many_foxes on AMD GPUs. This seems to be due to rounding or floating point precision issues combined with the absolute unit of a plane that it's currently using.

Related: #6542

I'm not sure if we want to close that issue, as there's still the underlying issue of shadows breaking on overly large planes.

## Solution

Make the plane smaller.
@bors bors bot changed the title Make the many_foxes plane smaller to fix shadow issues. [Merged by Bors] - Make the many_foxes plane smaller to fix shadow issues. Jan 23, 2023
@bors bors bot closed this Jan 23, 2023
@Elabajaba Elabajaba deleted the smaller_plane branch January 23, 2023 22:19
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
)

# Objective

Shadows are broken on many_foxes on AMD GPUs. This seems to be due to rounding or floating point precision issues combined with the absolute unit of a plane that it's currently using.

Related: bevyengine#6542

I'm not sure if we want to close that issue, as there's still the underlying issue of shadows breaking on overly large planes.

## Solution

Make the plane smaller.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants