Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Cam scale cluster fix #7078

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Cam scale cluster fix #7078

wants to merge 5 commits into from

Conversation

robtfm
Copy link
Contributor

@robtfm robtfm commented Jan 3, 2023

Objective

fix clustering calculations for cameras with non-unit scale

Solution

get view scale and apply to light range at various points

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Jan 3, 2023
alice-i-cecile
alice-i-cecile approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense to me, but I'm nervous about the pervasive lack of tests for this stuff. Is there a reasonable way to add some here?

@Elabajaba
Copy link
Contributor

I totally forgot about this.

It fixes the bugs I was seeing on the built-in animation in Bistro, but I don't understand how lighting works well enough to know if everything here is correct.

@alice-i-cecile alice-i-cecile added this to the 0.10 milestone Jan 31, 2023
@superdump
Copy link
Contributor

bors r+

bors bot pushed a commit that referenced this pull request Feb 7, 2023
@robtfm
Cam scale cluster fix (#7078)
4e17380 
# Objective

fix clustering calculations for cameras with non-unit scale

## Solution

get view scale and apply to light range at various points
@bors
Copy link
Contributor

bors bot commented Feb 7, 2023

Build failed:

@superdump
Copy link
Contributor

bors retry

bors bot pushed a commit that referenced this pull request Feb 7, 2023
@robtfm
Cam scale cluster fix (#7078)
5581cfe 
# Objective

fix clustering calculations for cameras with non-unit scale

## Solution

get view scale and apply to light range at various points
@bors
Copy link
Contributor

bors bot commented Feb 7, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Cam scale cluster fix [Merged by Bors] - Cam scale cluster fix Feb 7, 2023
@bors bors bot closed this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.
4 participants
@robtfm @Elabajaba @superdump @alice-i-cecile