-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
[Merged by Bors] - Add "how to adopt pull requests" section #6895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
48aab46
Add "how to adopt pull requests" section
oCaioOliveira a49850a
Add aditional description to section How to adopt pull requests
oCaioOliveira d6d0b9d
Add suggestion
oCaioOliveira 21f55b7
Best rewrite of How to adopt pull requests
oCaioOliveira 002c62e
Add aditional description to How to adopt pull requests
oCaioOliveira 4dd3cb8
More context to example
oCaioOliveira 1a07dd7
Add aditional description to section How to adopt pull requests
oCaioOliveira 106a8c3
Fix ERRORS FOUND in MARKDOWN
oCaioOliveira cc9b59e
Fixes ERRORS FOUND in MARKDOWN
oCaioOliveira b4c9de6
Fixes typos
oCaioOliveira 8b156ad
Aditional description How to adopt pull requests
oCaioOliveira a0ca180
Aditional description to reason label S-Adopt-Me
oCaioOliveira 96e0ca0
Refactored phrase on section How To Adopt PR
oCaioOliveira b76a123
Add suggestions of fixe wording
oCaioOliveira File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -275,6 +275,26 @@ By giving feedback on this work (and related supporting work), you can help us m | |
| Finally, if nothing brings you more satisfaction than seeing every last issue labeled and all resolved issues closed, feel free to message @cart for a Bevy org role to help us keep things tidy. | ||
| As discussed in [*How we're organized*](#how-were-organized), this role only requires good faith and a basic understanding of our development process. | ||
|
|
||
| ### How to adopt pull requests | ||
|
|
||
| Occasionally authors of pull requests get busy or become unresponsive. | ||
|
||
| This is a natural part of any open source project. | ||
| To avoid blocking these efforts, these pull requests may be *adopted*, where another contributor creates a new pull request with the same content. | ||
| If there is an old pull request that is without updates, comment to the organization whether it is appropriate to add the | ||
| *[S-Adopt-Me](https://github.com/bevyengine/bevy/labels/S-Adopt-Me)* label, to indicate that it can be *adopted*. | ||
| If you plan on adopting a PR yourself, you can also leave a comment on the PR asking the author if they plan on returning. | ||
| If the author gives permission or simply doesn't respond after a few days, then it can be adopted. | ||
| This may sometimes even skip the labeling process since at that point the PR has been adopted by you. | ||
|
|
||
| With this label added, it's best practice to fork the original author's branch. | ||
| This ensures that they still get credit for working on it and that the commit history is retained. | ||
| When the new pull request is ready, it should reference the original PR in the description. | ||
| Then notify org members to close the original. | ||
|
|
||
| * For example, you can reference the original PR by adding the following to your PR description: | ||
|
|
||
| `Adopted #number-original-pull-request` | ||
|
|
||
| ### Maintaining code | ||
|
|
||
| Maintainers can merge uncontroversial pull requests that have at least two approvals (or at least one for trivial changes). | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.