Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Remove APIs deprecated in 0.9 #6801

Closed
wants to merge 4 commits into from

Conversation

james7132
Copy link
Member

Objective

These functions were deprecated in 0.9. They should be removed in 0.10.

Solution

Remove them.

@james7132 james7132 added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Nov 30, 2022
@james7132 james7132 added this to the 0.10 milestone Nov 30, 2022
@mockersf
Copy link
Member

some doc to update and should be good to go 👍

@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 30, 2022
@tim-blackbird
Copy link
Contributor

tim-blackbird commented Nov 30, 2022

ChildBuilder and WorldChildBuilder also have the deprecated spawn_bundle method.

There's also a comment in archetype.rs that mentions spawn_bundle

@cart
Copy link
Member

cart commented Dec 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Dec 5, 2022
# Objective
These functions were deprecated in 0.9. They should be removed in 0.10.

## Solution
Remove them.
@bors bors bot changed the title Remove APIs deprecated in 0.9 [Merged by Bors] - Remove APIs deprecated in 0.9 Dec 5, 2022
@bors bors bot closed this Dec 5, 2022
ickshonpe pushed a commit to ickshonpe/bevy that referenced this pull request Dec 6, 2022
# Objective
These functions were deprecated in 0.9. They should be removed in 0.10.

## Solution
Remove them.
@james7132 james7132 deleted the remove-0.9-deprecated branch December 12, 2022 04:01
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
# Objective
These functions were deprecated in 0.9. They should be removed in 0.10.

## Solution
Remove them.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective
These functions were deprecated in 0.9. They should be removed in 0.10.

## Solution
Remove them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants