Skip to content

Add Color::TRANSPARENT #6530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GuillaumeGomez wants to merge 1 commit into from
Closed

Add Color::TRANSPARENT #6530

GuillaumeGomez wants to merge 1 commit into from

Conversation

@GuillaumeGomez
Copy link
Contributor

@GuillaumeGomez GuillaumeGomez commented Nov 9, 2022

I was looking for a fully transparent Color and only realize after a long while that Color::NONE was what I was looking for. This is really just a commodity because I think some other people have have stumbled on this. If you think it's useless, please close the PR.

@IceSentry
Copy link
Contributor

IceSentry commented Nov 9, 2022

Did you commit the right thing? I'm not sure the code is related to adding a new Color

@GuillaumeGomez
Copy link
Contributor Author

GuillaumeGomez commented Nov 9, 2022

... I pushed to the wrong branch. I was updating #6001 in parallel. Fearless concurrency isn't a thing with git. 😆

@IceSentry IceSentry added A-Utils Utility functions and types C-Feature A new feature, making something new possible labels Nov 9, 2022
@mockersf
Copy link
Member

mockersf commented Nov 9, 2022

so... what color is transparent? 🤔

@GuillaumeGomez
Copy link
Contributor Author

GuillaumeGomez commented Nov 9, 2022

Well, at least in french we say "this glass is transparent", so I guess it's a color? ^^'

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use A-UI Graphical user interfaces, styles, layouts, and widgets and removed C-Feature A new feature, making something new possible A-Utils Utility functions and types labels Nov 10, 2022
@tguichaoua
Copy link
Contributor

tguichaoua commented Nov 10, 2022

Is it pertinent to display a colored square in the doc ?
I know it's for the sake of consistency, but it's a bit confusing.

image

@GuillaumeGomez
Copy link
Contributor Author

GuillaumeGomez commented Nov 10, 2022

I took the same HTML as for NONE. So if it's unwanted, I can remove it for both.

@cart
Copy link
Member

cart commented Nov 14, 2022

From my perspective, "transparent" is not a specific color, it is any color with an alpha value of 0.0. There are color algorithms (ex: blending) where the RGB values of a "fully transparent" color matter (ex: in this PR you chose a "black" transparency, but "white" transparency is often equally valid / desirable).

Imo exposing this concept is a lossy abstraction that could cause actual harm.

@GuillaumeGomez GuillaumeGomez deleted the color-transparent branch November 15, 2022 09:59
@GuillaumeGomez
Copy link
Contributor Author

GuillaumeGomez commented Jan 11, 2023

One question: would you accept to add a "doc alias" on Color::NONE so that it is displayed when looking for "transparent"? I can send a PR for that too.

@alice-i-cecile
Copy link
Member

alice-i-cecile commented Jan 11, 2023

One question: would you accept to add a "doc alias" on Color::NONE so that it is displayed when looking for "transparent"? I can send a PR for that too.

I'd merge that in a heartbeat.

@GuillaumeGomez
Copy link
Contributor Author

GuillaumeGomez commented Jan 11, 2023

Thanks for the quick answer. Then here we go!

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 11, 2023
Closed
bors bot pushed a commit that referenced this pull request Jan 11, 2023
@GuillaumeGomez
Add "transparent" doc alias for Color::NONE (#7160)
15ee98d 
As mentioned in #6530. It allows to not create a new constant and simply having it to show up in the documentation when someone is looking for "transparent" (case insensitive) in rustdoc search.

cc @alice-i-cecile
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@GuillaumeGomez @alradish
Add "transparent" doc alias for Color::NONE (bevyengine#7160)
938325a 
As mentioned in bevyengine#6530. It allows to not create a new constant and simply having it to show up in the documentation when someone is looking for "transparent" (case insensitive) in rustdoc search.

cc @alice-i-cecile
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@GuillaumeGomez @ItsDoot
Add "transparent" doc alias for Color::NONE (bevyengine#7160)
a240f2a 
As mentioned in bevyengine#6530. It allows to not create a new constant and simply having it to show up in the documentation when someone is looking for "transparent" (case insensitive) in rustdoc search.

cc @alice-i-cecile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

+1 more reviewer

@IceSentry IceSentry IceSentry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez @IceSentry @mockersf @tguichaoua @cart @alice-i-cecile