Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Improve Command(s) docs #4994

Closed
wants to merge 1 commit into from

Conversation

LoipesMas
Copy link
Contributor

Objective

Solution

  • Update and improve documentation.

  • "list" -> "queue" in Commands doc (this better represents reality)
  • expand Command doc
  • update/improve Commands::add doc, as specified in linked issue

Let me know if you want any changes!

@Weibye Weibye added C-Docs An addition or correction to our documentation A-ECS Entities, components, systems, and events labels Jun 12, 2022
@alice-i-cecile
Copy link
Member

Oddly flaky test 🤔

bors try

bors bot added a commit that referenced this pull request Jun 12, 2022
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job on the examples.

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Jul 2, 2022
# Objective

- Improve Command(s) docs
- Fixes #4737 

## Solution

- Update and improve documentation.

---
- "list" -> "queue" in `Commands` doc (this better represents reality)
- expand `Command` doc
- update/improve `Commands::add` doc, as specified in linked issue

Let me know if you want any changes!
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 2, 2022
@bors bors bot changed the title Improve Command(s) docs [Merged by Bors] - Improve Command(s) docs Jul 2, 2022
@bors bors bot closed this Jul 2, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
# Objective

- Improve Command(s) docs
- Fixes bevyengine#4737 

## Solution

- Update and improve documentation.

---
- "list" -> "queue" in `Commands` doc (this better represents reality)
- expand `Command` doc
- update/improve `Commands::add` doc, as specified in linked issue

Let me know if you want any changes!
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

- Improve Command(s) docs
- Fixes bevyengine#4737 

## Solution

- Update and improve documentation.

---
- "list" -> "queue" in `Commands` doc (this better represents reality)
- expand `Command` doc
- update/improve `Commands::add` doc, as specified in linked issue

Let me know if you want any changes!
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

- Improve Command(s) docs
- Fixes bevyengine#4737 

## Solution

- Update and improve documentation.

---
- "list" -> "queue" in `Commands` doc (this better represents reality)
- expand `Command` doc
- update/improve `Commands::add` doc, as specified in linked issue

Let me know if you want any changes!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the Commands::add docs more representative of actual use cases
4 participants