Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - unpin nightly and disable weak memory emulation #4988

Closed
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,20 +76,18 @@ jobs:
timeout-minutes: 60
steps:
- uses: actions/checkout@v3
# TODO: re-enable cache once nightly is unpinned
# - uses: actions/cache@v3
# with:
# path: |
# ~/.cargo/bin/
# ~/.cargo/registry/index/
# ~/.cargo/registry/cache/
# ~/.cargo/git/db/
# target/
# key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.toml') }}
- uses: actions/cache@v3
with:
path: |
~/.cargo/bin/
~/.cargo/registry/index/
~/.cargo/registry/cache/
~/.cargo/git/db/
target/
key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.toml') }}
- uses: actions-rs/toolchain@v1
with:
# TODO: check again with nightly once https://github.com/rust-lang/miri/issues/2223 is fixed
toolchain: nightly-2022-06-08
toolchain: nightly
components: miri
override: true
- name: Install alsa and udev
Expand All @@ -104,7 +102,8 @@ jobs:
# to track down because allocids are nondeterministic.
# -Zmiri-tag-raw-pointers is not strictly "necessary" but enables a lot of extra UB checks relating
mockersf marked this conversation as resolved.
Show resolved Hide resolved
# to raw pointer aliasing rules that we should be trying to uphold.
mockersf marked this conversation as resolved.
Show resolved Hide resolved
MIRIFLAGS: -Zmiri-disable-isolation -Zmiri-ignore-leaks -Zmiri-tag-raw-pointers
# -Zmiri-disable-weak-memory-emulation works around an unknown bug in bevy or Miri
MIRIFLAGS: -Zmiri-disable-isolation -Zmiri-ignore-leaks -Zmiri-permissive-provenance -Zmiri-disable-weak-memory-emulation

check-compiles:
runs-on: ubuntu-latest
Expand Down