attempt work around rustc regression #4631
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Apr 29, 2022
alice-i-cecile
added
C-Bug
Member
|
Giving this P-Critical, because otherwise CI will fail on everything and we won't be able to merge anything. The regression in question: rust-lang/rust#96540 |
TheRawMeatball
approved these changes
Apr 29, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
I would rather wait for rust to fix the issue than work around it in Bevy. On the rust PR that introduces the issue it was mentioned they either want a quick fix or a revert soon |
Member
|
Regression appears to be addressed! rust-lang/rust#96559 Going to test this out on another PR, and see if that's fixed it for us. |
Member
|
Still failing: https://github.com/bevyengine/bevy/runs/6237109995?check_suite_focus=true. We should try again after the next nightly release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
CI is failing because of a rustc bug
Solution
Explicitly write out
'_instead of eliding it