[Merged by Bors] - Fixed case of R == G, following original conversion formula #4383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
mockersf
approved these changes
Apr 3, 2022
mockersf
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 4, 2022
https://en.wikipedia.org/wiki/HSL_and_HSV#From_RGB # Objective Fixes #4382 ## Solution - Describe the solution used to achieve the objective above. Fixed conversion formula to account for red and green component being max and equal --- ## Changelog Fixed RGB -> HSL colorspace conversion ## Migration Guide Co-authored-by: Francesco Giordana <[email protected]>
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
…ne#4383) https://en.wikipedia.org/wiki/HSL_and_HSV#From_RGB # Objective Fixes bevyengine#4382 ## Solution - Describe the solution used to achieve the objective above. Fixed conversion formula to account for red and green component being max and equal --- ## Changelog Fixed RGB -> HSL colorspace conversion ## Migration Guide Co-authored-by: Francesco Giordana <[email protected]>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…ne#4383) https://en.wikipedia.org/wiki/HSL_and_HSV#From_RGB # Objective Fixes bevyengine#4382 ## Solution - Describe the solution used to achieve the objective above. Fixed conversion formula to account for red and green component being max and equal --- ## Changelog Fixed RGB -> HSL colorspace conversion ## Migration Guide Co-authored-by: Francesco Giordana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://en.wikipedia.org/wiki/HSL_and_HSV#From_RGB
Objective
Fixes #4382
Solution
Fixed conversion formula to account for red and green component being max and equal
Changelog
Fixed RGB -> HSL colorspace conversion
Migration Guide