-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Remove unused CountdownEvent
#4290
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Tasks
Tools for parallel and async work
C-Code-Quality
A section of code that is hard to understand or change
and removed
S-Needs-Triage
This issue needs to be labelled
labels
Mar 21, 2022
mockersf
approved these changes
Mar 21, 2022
For context, this was first added in #437. It is not used internally, and I have not seen any external users of this API. It was previously used in our parallel executor code, but this usage was removed during the rewrite. |
alice-i-cecile
approved these changes
Mar 21, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
Mar 21, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
# Objective Fixes: #4287 ## Solution I removed it.
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
# Objective Fixes: #4287 ## Solution I removed it.
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
# Objective Fixes: #4287 ## Solution I removed it.
bors
bot
changed the title
Remove unused
[Merged by Bors] - Remove unused Apr 26, 2022
CountdownEvent
CountdownEvent
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
# Objective Fixes: bevyengine#4287 ## Solution I removed it.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes: bevyengine#4287 ## Solution I removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Tasks
Tools for parallel and async work
C-Code-Quality
A section of code that is hard to understand or change
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes:
#4287
Solution
I removed it.