[Merged by Bors] - bevy_render: Use RenderDevice to get limits/features and expose AdapterInfo #3931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superdump
added
A-Rendering
|
Ah...should have read more carefully, i think the two PRs have a different objective. |
|
Also renamed |
Weasy666
reviewed
Feb 14, 2022
There was a problem hiding this comment.
LGTM, but could you add module level docs, like mentioned by @alice-i-cecile #3832 (comment) ? To make people aware that AdapterInfo is available as a resource?
Done, with links. |
Weasy666
approved these changes
Feb 15, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
…erInfo (#3931) # Objective - `WgpuOptions` is mutated to be updated with the actual device limits and features, but this information is readily available to both the main and render worlds through the `RenderDevice` which has .limits() and .features() methods - Information about the adapter in terms of its name, the backend in use, etc were not being exposed but have clear use cases for being used to take decisions about what rendering code to use. For example, if something works well on AMD GPUs but poorly on Intel GPUs. Or perhaps something works well in Vulkan but poorly in DX12. ## Solution - Stop mutating `WgpuOptions `and don't insert the updated values into the main and render worlds - Return `AdapterInfo` from `initialize_renderer` and insert it into the main and render worlds - Use `RenderDevice` limits in the lighting code that was using `WgpuOptions.limits`. - Renamed `WgpuOptions` to `WgpuSettings`
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
WgpuOptionsis mutated to be updated with the actual device limits and features, but this information is readily available to both the main and render worlds through theRenderDevicewhich has .limits() and .features() methodsSolution
WgpuOptionsand don't insert the updated values into the main and render worldsAdapterInfofrominitialize_rendererand insert it into the main and render worldsRenderDevicelimits in the lighting code that was usingWgpuOptions.limits.WgpuOptionstoWgpuSettings