Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Enable Msaa for webgl by default #3489

Closed
wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Remove custom config for Msaa in webgl
  • I also changed two options that were using the arch instead of the webgl feature. it shouldn't change much for webgl, but could help if someone wants to target wasm but not webgl2

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 29, 2021
@mockersf mockersf added A-Rendering Drawing game state to the screen O-Web Specific to web (WASM) builds and removed S-Needs-Triage This issue needs to be labelled labels Dec 29, 2021
@cart
Copy link
Member

cart commented Dec 29, 2021

Love it!

@cart
Copy link
Member

cart commented Dec 29, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 29, 2021
# Objective

- `Msaa` was disabled in webgl due to a bug in wgpu
- Bug has been fixed (gfx-rs/wgpu#2307) and backported (gfx-rs/wgpu#2327), and updates for [`wgpu-core`](https://crates.io/crates/wgpu-core/0.12.1) and [`wgpu-hal`](https://crates.io/crates/wgpu-hal/0.12.1) have been released

## Solution

- Remove custom config for `Msaa` in webgl
- I also changed two options that were using the arch instead of the `webgl` feature. it shouldn't change much for webgl, but could help if someone wants to target wasm but not webgl2


Co-authored-by: François <[email protected]>
@bors bors bot changed the title Enable Msaa for webgl by default [Merged by Bors] - Enable Msaa for webgl by default Dec 29, 2021
@bors bors bot closed this Dec 29, 2021
mockersf added a commit to mockersf/bevy that referenced this pull request Jan 1, 2022
# Objective

- `Msaa` was disabled in webgl due to a bug in wgpu
- Bug has been fixed (gfx-rs/wgpu#2307) and backported (gfx-rs/wgpu#2327), and updates for [`wgpu-core`](https://crates.io/crates/wgpu-core/0.12.1) and [`wgpu-hal`](https://crates.io/crates/wgpu-hal/0.12.1) have been released

## Solution

- Remove custom config for `Msaa` in webgl
- I also changed two options that were using the arch instead of the `webgl` feature. it shouldn't change much for webgl, but could help if someone wants to target wasm but not webgl2


Co-authored-by: François <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen O-Web Specific to web (WASM) builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants