Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default UI node size #304

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Fix default UI node size #304

merged 3 commits into from
Aug 25, 2020

Conversation

stefee
Copy link
Contributor

@stefee stefee commented Aug 23, 2020

Fixes #291

This changes the default node size (width and height) to Auto instead of Undefined to match the Stretch implementation.

See comment #291 (comment), I think the solution in this comment would be better, but currently doesn't work with how the crates are structured.

@Moxinilian Moxinilian added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets labels Aug 24, 2020
crates/bevy_ui/src/flex/convert.rs Outdated Show resolved Hide resolved
@stefee stefee requested a review from cart August 25, 2020 16:33
@cart
Copy link
Member

cart commented Aug 25, 2020

Thanks! This looks good to go!

@cart cart merged commit 034b587 into bevyengine:master Aug 25, 2020
@stefee stefee deleted the fix-node-size-default branch August 25, 2020 19:31
BimDav pushed a commit to BimDav/bevy that referenced this pull request Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node size computed incorrectly(?) on cross axis for AlignItems::Stretch
3 participants