[Merged by Bors] - Fix scale_factor_override in the winit backend #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
added
A-Windowing
TheRawMeatball
approved these changes
Sep 7, 2021
TheRawMeatball
approved these changes
Sep 7, 2021
TheRawMeatball
approved these changes
Sep 7, 2021
TheRawMeatball
approved these changes
Sep 8, 2021
| @@ -23,6 +23,7 @@ bevy_utils = { path = "../bevy_utils", version = "0.5.0" } | |||
|
|
|||
| # other | |||
| winit = { version = "0.25.0", default-features = false } | |||
| approx = { version = "0.5.0", default-features = false } | |||
There was a problem hiding this comment.
Do we need a new crate? Wouldn't silencing clippy, or using epsilon work?
There was a problem hiding this comment.
Maybe? We already depend on this transitively in the bevy_text crate, and I don't think it's that big. I can make the function inline though.
There was a problem hiding this comment.
ah, if the dep already exists it's probably fine
There was a problem hiding this comment.
This feels small enough that it might be better to include it in bevy_core. We already have FloatOrd, which is in a similar vein. For now this is fine though.
mockersf
approved these changes
Sep 9, 2021
mockersf
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 10, 2021
# Objective - Fixes #2751 ## Solution - Avoid changing the window size if there is a scale factor override - Can be tested with the `scale_factor_override` example - use <kbd>⏎</kbd> to active overriding the scale factor
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
scale_factor_overrideexample - use ⏎ to active overriding the scale factor