Implement Send/Sync non-structurally for wgpu wrapper types - #25601
Open
SkiFire13 wants to merge 1 commit into
Open
Implement Send/Sync non-structurally for wgpu wrapper types#25601SkiFire13 wants to merge 1 commit into
SkiFire13 wants to merge 1 commit into
Conversation
Zeophlite
approved these changes
Aug 30, 2026
Member
|
If this is for 0.19, should it target a branch for 0.19 rather than the main branch? |
Contributor
Author
|
Yes, this would be for an eventual 0.19.2. Should I target 0.19.1 or some other branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
-Znext-solverenabled by default #25511Send/Synceagerly #25512 with roughly the same compilation time improvementsSolution
non_structural_deriveto short-circuit theSend/SynccheckingSend/Synceagerly #25512 this is not a breaking change, however it is less robust: we might unintentionally add a new wgpu wrapper type without the non-structural annotation, and this would regress without visible errors. It also requires an additional dependency (or a bunch of boilerplate to do it ourselves)Send/Synceagerly #25512 as a more robust solution for 0.20Testing
Not needed
Click to view showcase