Improve error message for EntityNotSpawnedError - Main Branch #22467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HugoPeters1024
approved these changes
Jan 10, 2026
Contributor
HugoPeters1024
left a comment
HugoPeters1024
left a comment
There was a problem hiding this comment.
LGTM! You make a valid point and this is a good solution
kfc35
approved these changes
Jan 10, 2026
kfc35
added
D-Trivial
alice-i-cecile
pushed a commit
that referenced
this pull request
Jan 13, 2026
main branch version of #22444 The new `0.18` entity errors feel a bit 'inside baseball' for end-users, for instance interacting with a despawned entity makes no mention of the entity not being spawned: ```rust let mut world = World::new(); let entity = world.spawn_empty().id(); world.entity_mut(entity).despawn(); world.entity(entity); // Panic: The entity with ID 27v0 is invalid; its index now has generation 1. ``` Ideally I'd like to implement proper rust-style errors with a short paragraph detailing common causes and links to docs but thats a bigger discussion. At least for `0.18` i think this very common error needs a prefix `Entity Not Spawned:` - Before: `The entity with ID 27v0 is invalid; its index now has generation 1.` - After: `Entity Not Spawned: The entity with ID 27v0 is invalid; its index now has generation 1.`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main branch version of #22444
The new
0.18entity errors feel a bit 'inside baseball' for end-users, for instance interacting with a despawned entity makes no mention of the entity not being spawned:Ideally I'd like to implement proper rust-style errors with a short paragraph detailing common causes and links to docs but thats a bigger discussion.
At least for
0.18i think this very common error needs a prefixEntity Not Spawned:The entity with ID 27v0 is invalid; its index now has generation 1.Entity Not Spawned: The entity with ID 27v0 is invalid; its index now has generation 1.