Remove EarthlikeAtmosphere resources #22463
Merged
+15
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart
added
A-Rendering
hukasu
approved these changes
Jan 9, 2026
hukasu
added
S-Ready-For-Final-Review
mate-h
approved these changes
Jan 9, 2026
Contributor
mate-h
left a comment
mate-h
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the cleanup!
ecoskey
approved these changes
Jan 9, 2026
ecoskey
added
S-Ready-For-Final-Review
cart
added a commit
that referenced
this pull request
Jan 10, 2026
# Objective #20838 introduced an `EarthlikeAtmosphere` resource, which has a pre-prepared scattering medium resource for earthlike atmospheres. This means that every deployed Bevy app (even apps that don't need an atmosphere, or don't need the default earthlike atmosphere) will initialize the earthlike scattering medium (which processes the asset and writes data to the gpu). This is not desirable. The UX benefits for atmosphere initializers are not worth the price being paid: ```rust // EarthlikeAtmosphere resource fn setup(mut commands: Commands, earth_atmosphere: Res<EarthlikeAtmosphere>) { commands.spawn(( Camera3d::default(), earth_atmosphere.get(), )); } // Manual initialization fn setup(mut commands: Commands, mut scattering_mediums: ResMut<Assets<ScatteringMedium>>,) { commands.spawn(( Camera3d::default(), Atmosphere::earthlike(scattering_mediums.add(ScatteringMedium::default())), )); } ``` The manual approach also puts the Atmosphere component symbol back at the forefront and helps instruct developers on how this all actually works. ## Solution Remove the EarthlikeAtmosphere resource and add a default ScatteringMedium impl to make init slightly easier. As this feature will be introduced in 0.18, to avoid breaking people down the road we should land this PR in 0.18 as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
#20838 introduced an
EarthlikeAtmosphereresource, which has a pre-prepared scattering medium resource for earthlike atmospheres.This means that every deployed Bevy app (even apps that don't need an atmosphere, or don't need the default earthlike atmosphere) will initialize the earthlike scattering medium (which processes the asset and writes data to the gpu).
This is not desirable. The UX benefits for atmosphere initializers are not worth the price being paid:
The manual approach also puts the Atmosphere component symbol back at the forefront and helps instruct developers on how this all actually works.
Solution
Remove the EarthlikeAtmosphere resource and add a default ScatteringMedium impl to make init slightly easier.
As this feature will be introduced in 0.18, to avoid breaking people down the road we should land this PR in 0.18 as well.