Fix problems displaying grid gizmos #21502
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
alice-i-cecile
added
the
S-Needs-Design
|
Reverting this will reintroduce the bug it was fixing |
|
Yeah, ideally we can fix the original bug and not regress this. |
|
I think i know how this has to be fixed. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 13, 2025
# Objective - alternative to #21502 - also undoes #20890 - does not regress #19205 - fixes #21489 and #21479 ## Solution the fix i originally made was wrong. the reason it worked was because it failed the conditional and did not clip the lines in some cases where the original bug was exhibited. the condition was correct before, it turns out, but the clipping logic is wrong: an epsilon is added, with a comment saying it is to avoid falsely culling the vertex due to floating point imprecision leaving it just barely in front of the near plane. However, i do not see why an epsilon should be needed here, or why this should be avoided: triangle primitives are regularly intersecting the clipping plane, that is standard order of business. The entire primitive is not discarded if only part of it is clipped, instead only the visible pixels are rasterized. ## Testing - original bug test case by Antony looks right - both grid test cases look right - gizmos examples look right
mate-h
pushed a commit
to mate-h/bevy
that referenced
this pull request
Oct 22, 2025
# Objective - alternative to bevyengine#21502 - also undoes bevyengine#20890 - does not regress bevyengine#19205 - fixes bevyengine#21489 and bevyengine#21479 ## Solution the fix i originally made was wrong. the reason it worked was because it failed the conditional and did not clip the lines in some cases where the original bug was exhibited. the condition was correct before, it turns out, but the clipping logic is wrong: an epsilon is added, with a comment saying it is to avoid falsely culling the vertex due to floating point imprecision leaving it just barely in front of the near plane. However, i do not see why an epsilon should be needed here, or why this should be avoided: triangle primitives are regularly intersecting the clipping plane, that is standard order of business. The entire primitive is not discarded if only part of it is clipped, instead only the visible pixels are rasterized. ## Testing - original bug test case by Antony looks right - both grid test cases look right - gizmos examples look right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #21489 #21479;
Undoes #20890
Solution
PR #20890 causes the issues in #21489 and #21479, where grid gizmos display incorrectly. Undoing it removes those issues.
Testing
Ran the examples from #21489 and #21479.
NOTE:
Tried to run CI tests but my computer didn't have space 😅 would appreciate checks that I didn't break anything
Also, I'm not very familiar with the Bevy codebase, so i don't really understand why these problems existed, or why #20890 caused them, but I would appreciate an explanation :)