Rename "raw" in entity methods into "row" #21262
Merged
+62
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think "raw" is a leftover from old methods where a raw u32 value was accepted. Since we pass a _row_ now, I think it worth renaming. I also adjusted the comment since the generation can be zero now.
alice-i-cecile
approved these changes
Sep 28, 2025
alice-i-cecile
added
D-Trivial
|
I agree: this is much clearer and looks less like a typo. |
mockersf
pushed a commit
that referenced
this pull request
Sep 28, 2025
# Objective I think "raw" is a leftover from old Entity methods where a raw u32 value was accepted. Since we pass a _row_ now, I think it worth renaming. ## Solution - Adjusted a single letter in 2 methods 😅 - While at it, adjusted the comment about generation since it can be zero since #19121.
mockersf
pushed a commit
that referenced
this pull request
Sep 28, 2025
# Objective I think "raw" is a leftover from old Entity methods where a raw u32 value was accepted. Since we pass a _row_ now, I think it worth renaming. ## Solution - Adjusted a single letter in 2 methods 😅 - While at it, adjusted the comment about generation since it can be zero since #19121.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
I think "raw" is a leftover from old Entity methods where a raw u32 value was accepted. Since we pass a row now, I think it worth renaming.
Solution