-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Raymarched rendering for atmosphere and spherical coordinates #20766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raymarched rendering for atmosphere and spherical coordinates #20766
Conversation
|
It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note. Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes. |
|
It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note. Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes. |
Which part fixes that? Also this is #19131 |
Co-authored-by: atlv <[email protected]>
release-content/release-notes/raymarched-atmosphere-space-views.md
Outdated
Show resolved
Hide resolved
|
Thanks for the comments! I think everything has been addressed, including what to do for when the camera is inside of the earth. I update the atmosphere example here for testing but decided not to include it in this PR to avoid more scope. I would say at this stage it's ready for a final review. I updated the PR description with a new demo video. |
release-content/release-notes/raymarched-atmosphere-space-views.md
Outdated
Show resolved
Hide resolved
release-content/release-notes/raymarched-atmosphere-space-views.md
Outdated
Show resolved
Hide resolved
release-content/release-notes/raymarched-atmosphere-space-views.md
Outdated
Show resolved
Hide resolved
atlv24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fully happy with these changes now. Thanks for being patient :)
One last thing i'd consider is if view_pos never gets used directly (always immediately fed to length+normalize to get r and up) then maybe having get_view_position return a struct that has an up and radius field would make sense. Happy with it as is though, thanks for all the work!
|
@alice-i-cecile this one is ready for a final review and merge! |
alice-i-cecile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this too :) Quite clear, and a feature that a lot of our devs will love.
Objective
Solution
Testing
Showcase
Screen.Recording.2025-09-02.at.12.28.35.AM.mov