Fix ComponentsRegistrator unsoundness
#20187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkiFire13
force-pushed
the
fix-components-registrator-unsoundness
branch
from
7ab3413 to
c7d5ec6
Compare
hymm
approved these changes
Jul 18, 2025
There was a problem hiding this comment.
Makes sense to me. &mut Components should definitely never be exposed to users. I do wonder if it's even worth exposing any_queued_mut and num_queued_mut as they seem pretty niche and are just faster versions of any_queued and num_queued. Feels like it's not worth complicating the api of ComponentsRegistrator for that. But I don't see any problems arising from exposing them. So not a big deal.
JaySpruce
approved these changes
Jul 19, 2025
JaySpruce
added
A-ECS
alice-i-cecile
added
the
P-Unsound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
ComponentsRegistratorexposes access to&mut Components#20174Solution
DerefMutforComponentsRegistratorany_queued_mutandnum_queued_mutonComponentsRegistrator. These are the only methods taking&mut selfonComponentsand for which theDerefMutimpl could have been useful for.