Skip to content

don't mark as modified removed asset if the are RENDER_WORLD only #18829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

don't mark as modified removed asset if the are RENDER_WORLD only #18829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion crates/bevy_render/src/render_asset.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,15 @@ pub(crate) fn extract_render_asset<A: RenderAsset>(
// Removed to ensure that the asset is always "really" removed from the
// render world when the last strong handle is dropped.
if !removed.contains(id) {
modified.insert(*id);
// Assets that are RENDER_WORLD only are expected to be removed from the main world
// without impact in the render world. Only trigger a modification if the asset is
// also used in the MAIN_WORLD.
if let Some(asset) = assets.get(*id) {
let asset_usage = A::asset_usage(asset);
if asset_usage.contains(RenderAssetUsages::MAIN_WORLD) {
modified.insert(*id);
}
}
}
}
AssetEvent::Unused { id } => {
Expand Down