Skip to content

Conversation

@tychedelia
Copy link
Member

@tychedelia tychedelia commented Apr 11, 2025

Objective

Fixes #18808

Solution

When an asset emits a removed event, mark it as modified in the render world to ensure any appropriate bookkeeping runs as necessary.

@tychedelia tychedelia added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 11, 2025
@tychedelia tychedelia requested a review from JMS55 April 11, 2025 19:44
@mockersf mockersf added this to the 0.16 milestone Apr 11, 2025
Copy link
Contributor

@LikeLakers2 LikeLakers2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mockersf mockersf added this pull request to the merge queue Apr 11, 2025
Merged via the queue into bevyengine:main with commit a9b0b4e Apr 11, 2025
32 checks passed
mockersf pushed a commit that referenced this pull request Apr 14, 2025
…8814)

# Objective

Fixes #18808

## Solution

When an asset emits a removed event, mark it as modified in the render
world to ensure any appropriate bookkeeping runs as necessary.
tychedelia added a commit to tychedelia/bevy that referenced this pull request Apr 15, 2025
jf908 pushed a commit to jf908/bevy that referenced this pull request May 12, 2025
…vyengine#18814)

# Objective

Fixes bevyengine#18808

## Solution

When an asset emits a removed event, mark it as modified in the render
world to ensure any appropriate bookkeeping runs as necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

GPU memory leak when removing then inserting a mesh from Assets

3 participants