Skip to content

Fix forward decal depth_fade_factor. #18772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2025
Merged

Fix forward decal depth_fade_factor. #18772

merged 3 commits into from
Apr 9, 2025

Conversation

@tychedelia
Copy link
Member

@tychedelia tychedelia commented Apr 9, 2025

Fixes #18758

@tychedelia tychedelia added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 9, 2025
@tychedelia tychedelia added this to the 0.16 milestone Apr 9, 2025
@tychedelia tychedelia requested a review from JMS55 April 9, 2025 00:38
@alice-i-cecile alice-i-cecile added the D-Straightforward Simple bug fixes and API improvements, docs, test and examples label Apr 9, 2025
JMS55
JMS55 reviewed Apr 9, 2025
View reviewed changes
@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 9, 2025
@tychedelia tychedelia added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Apr 9, 2025
@superdump superdump enabled auto-merge April 9, 2025 21:49
@superdump superdump added this pull request to the merge queue Apr 9, 2025
Merged via the queue into bevyengine:main with commit ee7b624 Apr 9, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this to Done in Rendering Apr 9, 2025
mockersf pushed a commit that referenced this pull request Apr 9, 2025
@tychedelia @mockersf
Fix forward decal depth_fade_factor. (#18772)
ef8a4e0 
Fixes #18758
jf908 pushed a commit to jf908/bevy that referenced this pull request May 12, 2025
@tychedelia @jf908
Fix forward decal depth_fade_factor. (bevyengine#18772)
fb00206 
Fixes bevyengine#18758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@superdump superdump superdump approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@JMS55 JMS55 JMS55 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

Rendering
Status: Done

Milestone

0.16

Development

Successfully merging this pull request may close these issues.

ForwardDecalMaterialExt::depth_fade_factor's description is inverse to its behavior.

4 participants

@tychedelia @superdump @alice-i-cecile @JMS55