Skip to content

Fix documentation: incorrect references to the Update schedule in ExitCondition #18438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

Fix documentation: incorrect references to the Update schedule in ExitCondition #18438

merged 1 commit into from
Apr 10, 2025

Conversation

@Henauxg
Copy link
Contributor

@Henauxg Henauxg commented Mar 20, 2025 •
edited
Loading

Objective

  • The referenced ScheduleLabel for OnPrimaryClosed and OnAllClosed in ExitCondition was incorrect

Solution

  • Changed Update to PostUpdate

@kristoff3r kristoff3r added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 20, 2025
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Apr 10, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 10, 2025
@mockersf mockersf added this pull request to the merge queue Apr 10, 2025
Merged via the queue into bevyengine:main with commit e7558cd Apr 10, 2025
38 checks passed
mockersf pushed a commit that referenced this pull request Apr 10, 2025
@Henauxg @mockersf
Fix documentation: incorrect references to the Update schedule in `…
9ef8d19 
…ExitCondition` (#18438)

# Objective

- The referenced `ScheduleLabel` for `OnPrimaryClosed` and `OnAllClosed`
in `ExitCondition` was incorrect

## Solution

- Changed `Update` to `PostUpdate`
jf908 pushed a commit to jf908/bevy that referenced this pull request May 12, 2025
@Henauxg @jf908
Fix documentation: incorrect references to the Update schedule in `…
aaeefa6 
…ExitCondition` (bevyengine#18438)

# Objective

- The referenced `ScheduleLabel` for `OnPrimaryClosed` and `OnAllClosed`
in `ExitCondition` was incorrect

## Solution

- Changed `Update` to `PostUpdate`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mockersf mockersf mockersf approved these changes

+2 more reviewers

@kristoff3r kristoff3r kristoff3r approved these changes

@AlephCubed AlephCubed AlephCubed approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.16

Development

Successfully merging this pull request may close these issues.

5 participants

@Henauxg @kristoff3r @mockersf @AlephCubed @alice-i-cecile