Fix bevy_ecs doc tests with --all-features
#18424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Docs
mockersf
pushed a commit
that referenced
this pull request
Mar 19, 2025
## Objective Fix `bevy_ecs` doc tests failing when used with `--all-features`. ``` ---- crates\bevy_ecs\src\error\handler.rs - error::handler::GLOBAL_ERROR_HANDLER (line 87) stdout ---- error[E0425]: cannot find function `default_error_handler` in this scope --> crates\bevy_ecs\src\error\handler.rs:92:24 | 8 | let error_handler = default_error_handler(); | ^^^^^^^^^^^^^^^^^^^^^ not found in this scope ``` I happened to come across this while testing #12207. I'm not sure it actually needs fixing but seemed worth a go ## Testing ``` cargo test --doc -p bevy_ecs --all-features ``` ## Side Notes The CI misses this error as it doesn't use `--all-features`. Perhaps it should? I tried adding `--all-features` to `ci/src/commands/doc_tests.rs` but this triggered a linker error: ``` Compiling bevy_dylib v0.16.0-dev (C:\Projects\bevy\crates\bevy_dylib) error: linking with `link.exe` failed: exit code: 1189 = note: LINK : fatal error LNK1189: library limit of 65535 objects exceeded␍ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix
bevy_ecsdoc tests failing when used with--all-features.I happened to come across this while testing #12207. I'm not sure it actually needs fixing but seemed worth a go
Testing
Side Notes
The CI misses this error as it doesn't use
--all-features. Perhaps it should?I tried adding
--all-featurestoci/src/commands/doc_tests.rsbut this triggered a linker error: