bevy_render: Derive Error on ViewportConversionError
#18336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The
ViewportConversionErrorerror type does not implementError, making it incompatible withBevyError.Solution
Derive
ErrorforViewportConversionError.I chose to use
thiserrorsince it's already a dependency, but do let me know if we should be preferringderive_more.Testing
You can test this by trying to compile the following: