Skip to content

Conversation

@MrGVSV
Copy link
Member

@MrGVSV MrGVSV commented Mar 16, 2025

Objective

The ViewportConversionError error type does not implement Error, making it incompatible with BevyError.

Solution

Derive Error for ViewportConversionError.

I chose to use thiserror since it's already a dependency, but do let me know if we should be preferring derive_more.

Testing

You can test this by trying to compile the following:

let error: BevyError = ViewportConversionError::InvalidData.into();

@MrGVSV MrGVSV added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 16, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 16, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 16, 2025
Merged via the queue into bevyengine:main with commit 137451b Mar 16, 2025
37 checks passed
@MrGVSV MrGVSV deleted the mrgvsv/render/viewport-conversion-error branch March 16, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants