Skip to content

Small cleanup for ECS error handling #18280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 13, 2025
Merged

Small cleanup for ECS error handling #18280

merged 5 commits into from
Mar 13, 2025

Conversation

@alice-i-cecile
Copy link
Member

@alice-i-cecile alice-i-cecile commented Mar 12, 2025 •
edited
Loading

Objective

While poking at #17272, I noticed a few small things to clean up.

Solution

  • Improve the docs
  • move SystemErrorContext out of the handler.rs module: it's not an error handler

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 12, 2025
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Mar 12, 2025
cart
cart reviewed Mar 12, 2025
View reviewed changes
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy and removed D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Mar 12, 2025
@cart cart added this pull request to the merge queue Mar 13, 2025
Merged via the queue into bevyengine:main with commit ab0e3f8 Mar 13, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cart cart cart approved these changes

+1 more reviewer

@mnmaita mnmaita mnmaita approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Uncontroversial This work is generally agreed upon

Projects

None yet

Milestone

0.16

Development

Successfully merging this pull request may close these issues.

3 participants

@alice-i-cecile @cart @mnmaita