Skip to content

bevy_ui: Apply #![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] #17229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 8, 2025
Merged

bevy_ui: Apply #![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] #17229

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
33e311b
(Mostly) Apply `#![deny(clippy::allow_attributes, clippy::allow_attri…
LikeLakers2 Jan 8, 2025
c0adf5c
Mark the unreachable code as expected, and link to an issue where the…
LikeLakers2 Jan 8, 2025
697de46
Change the issue/PR number we're referring to in the `expect(unreacha…
LikeLakers2 Jan 8, 2025
eae728e
Re-add `#![deny(missing_docs)]` that I accidentally removed
LikeLakers2 Jan 8, 2025
da73c95
Seems I missed an `allow()`...
LikeLakers2 Jan 8, 2025
7c88254
This is why you test locally before pushing commits
LikeLakers2 Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions crates/bevy_ui/src/layout/ui_surface.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,10 @@ mod tests {
);
}

#[allow(unreachable_code)]
#[expect(
unreachable_code,
reason = "Certain pieces of code tested here cause the test to fail if made reachable; see #17231 for progress on fixing this"
)]
Copy link
Contributor Author

@LikeLakers2 LikeLakers2 Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not proficient enough in bevy_ui to know if we should merge these expects that I added to crates/bevy_ui/src/layout/ui_surface.rs, or if we should wait until #17231 is fixed.

Copy link
Contributor Author

@LikeLakers2 LikeLakers2 Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was informed that there's already a PR for this: #16362

#[test]
fn test_remove_camera_entities() {
let mut ui_surface = UiSurface::default();
Expand Down Expand Up @@ -512,7 +515,10 @@ mod tests {
assert_eq!(root_node_pair, None);
}

#[allow(unreachable_code)]
#[expect(
unreachable_code,
reason = "Certain pieces of code tested here cause the test to fail if made reachable; see #17231 for progress on fixing this"
)]
#[test]
fn test_remove_entities() {
let mut ui_surface = UiSurface::default();
Expand Down Expand Up @@ -592,7 +598,10 @@ mod tests {
assert_eq!(ui_surface.taffy.parent(child_node), Some(parent_node));
}

#[allow(unreachable_code)]
#[expect(
unreachable_code,
reason = "Certain pieces of code tested here cause the test to fail if made reachable; see #17231 for progress on fixing this"
)]
#[test]
fn test_set_camera_children() {
let mut ui_surface = UiSurface::default();
Expand Down
Loading