Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default UI camera extraction fix #17100

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

default UI camera extraction fix #17100

wants to merge 3 commits into from
+15 −12

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Jan 2, 2025 •
edited
Loading

Objective

In UI extraction the default UI camera is queried for every UI node. It only needs to be retrieved once.

Solution

Query for the default UI camera once before iterating the UI nodes.

cargo run --example many_buttons --release --features "trace_tracy"
default-camera-extract

extract_uinode_background_colors yellow is this PR, red is main.

@alice-i-cecile alice-i-cecile added C-Performance A change motivated by improving speed, memory usage or compile times A-UI Graphical user interfaces, styles, layouts, and widgets labels Jan 2, 2025
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 2, 2025
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Jan 2, 2025
@alice-i-cecile alice-i-cecile requested a review from atlv24 January 2, 2025 20:59
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@atlv24 atlv24 Awaiting requested review from atlv24

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Performance A change motivated by improving speed, memory usage or compile times D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: No status
Milestone
0.16
Development

Successfully merging this pull request may close these issues.
3 participants
@ickshonpe @alice-i-cecile @BenjaminBrienen