-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[Merged by Bors] - expose stages and system containers #1647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
4a3fcf2
a1a4d8d
c4ec1c2
3e22fbb
dc995b1
1cd12f6
f721f27
1c3ed5a
779af77
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,9 +9,12 @@ use crate::{ | |
| }; | ||
| use std::{borrow::Cow, ptr::NonNull}; | ||
|
|
||
| pub(super) trait SystemContainer { | ||
| /// System metadata like its name, labels, order requirements and component access. | ||
| pub trait SystemContainer { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This wasn't intended to be exposed, but I suppose it won't be a problem, as long as there's no mutable access. Ideally, it should be documented as well.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The only thing that's mutable is
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could add
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| fn name(&self) -> Cow<'static, str>; | ||
| #[doc(hidden)] | ||
| fn dependencies(&self) -> &[usize]; | ||
| #[doc(hidden)] | ||
| fn set_dependencies(&mut self, dependencies: impl IntoIterator<Item = usize>); | ||
| fn system_set(&self) -> usize; | ||
| fn labels(&self) -> &[BoxedSystemLabel]; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This applies to all systems.