Default UI shadow samples fix #15953
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which results in the number of shadow samples being set to `u32::default()` instead of `UiBoxShadows::default()` if the camera entity doesn't have the component. This PR fixes the unwrap so that the number of samples is set correctly.
ickshonpe
added
A-UI
alice-i-cecile
approved these changes
Oct 16, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
|
Great PR description: really clearly communicates the bug and the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
In
queue_shadows, theUiBoxShadowsoption is unwrapped incorrectly which results in the number of shadow samples being set tou32::default()instead ofUiBoxShadows::default()if the camera entity doesn't have the component.Solution
Just use
unwrap_or_defaultdirectly withoutmap.