Skip to content

Allow users to choose how Commands and EntityCommands should fail #15929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 33 commits into from
Closed

Allow users to choose how Commands and EntityCommands should fail #15929

Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
5e2bbba
working prototype
JaySpruce Oct 15, 2024
9096ee3
add actual errors
JaySpruce Oct 16, 2024
ab35a4f
remove checks that can no longer trigger
JaySpruce Oct 16, 2024
f36780d
implement for niche variant of EntityCommand
JaySpruce Oct 16, 2024
d54ff94
derive default, wire up `EntityEntryCommands`
JaySpruce Oct 16, 2024
60e5703
move `failure_mode` to `Commands`, implement for fallible
JaySpruce Oct 16, 2024
586da95
maintain `failure_mode` when reborrowing
JaySpruce Oct 16, 2024
3650347
allow `Commands::entity` to return invalid `EntityCommands`
JaySpruce Oct 16, 2024
40b6b03
added convenience method
JaySpruce Oct 16, 2024
3ac66ec
add docs and update existing docs
JaySpruce Oct 17, 2024
2f4f8a1
doc tidbits
JaySpruce Oct 17, 2024
ba826f2
more docs and fix get_entity
JaySpruce Oct 17, 2024
dd4d4e9
minor spelling mistake
JaySpruce Oct 17, 2024
e64db6d
a smidgen of docs
JaySpruce Oct 17, 2024
c184014
a little more docs
JaySpruce Oct 17, 2024
f600a17
fix ignore performance
JaySpruce Oct 18, 2024
eea892f
fix warn performance
JaySpruce Oct 18, 2024
5fb2be9
ci knows best
JaySpruce Oct 18, 2024
b364e09
semicolons
JaySpruce Oct 18, 2024
581e54b
remove bad convenience method
JaySpruce Oct 19, 2024
1f4e7d0
move check from `apply` to `with_entity`
JaySpruce Oct 20, 2024
950c2c7
Merge branch 'main' into entity_command_failure
JaySpruce Oct 20, 2024
001634c
conflict resolve left a space RIP
JaySpruce Oct 20, 2024
1916616
allergic to "to"??
JaySpruce Oct 24, 2024
b129f1f
address comments
JaySpruce Oct 28, 2024
791a1f0
change default from log to panic, remove unused pub(crate)
JaySpruce Dec 2, 2024
a6db187
Merge branch 'main' into entity_command_failure
JaySpruce Dec 2, 2024
374aad5
add method to allow `try_` variants and `despawn` to fail uniquely
JaySpruce Dec 2, 2024
c8e2bae
set internal commands to old behavior to avoid breaking stuff
JaySpruce Dec 3, 2024
0248dd1
tidy up docs
JaySpruce Dec 4, 2024
370b5fb
Merge branch 'main' into entity_command_failure
JaySpruce Dec 4, 2024
771d6ff
oopsie
JaySpruce Dec 4, 2024
c86590f
Merge branch 'main' into entity_command_failure
JaySpruce Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading