Skip to content

Conversation

@DasLixou
Copy link
Contributor

@DasLixou DasLixou commented Sep 9, 2024

Objective

Fixes #15121 (hopefully, just read the docs, don't know how to test this tho)

Solution

Adds write permissions for pull-requests, see https://docs.github.com/en/rest/issues/comments?apiVersion=2022-11-28#create-an-issue-comment--fine-grained-access-tokens for more information.

@DasLixou DasLixou changed the title Update welcome.yml Fix Welcome Contributors CI Sep 9, 2024
@alice-i-cecile alice-i-cecile added A-Build-System Related to build systems or continuous integration S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Bug An unexpected or incorrect behavior labels Sep 9, 2024
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this looks related to our recent auto-upgrade to Github Enterprise.

@mockersf
Copy link
Member

mockersf commented Sep 9, 2024

I tried fixing it in bevyengine/bevy-website#1625 and was waiting for it to be merged to confirm

Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should work, though it is hard to test until this is merged. 👍

@BD103 BD103 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 9, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 9, 2024
@alice-i-cecile
Copy link
Member

Merging both; let's see how it works out.

Merged via the queue into bevyengine:main with commit a5c4606 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Welcome new contributors workflow is failing

4 participants