Use associated type bounds for iter_many and friends
#15040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-blackbird
added
A-ECS
tim-blackbird
commented
Sep 4, 2024
| @@ -1334,15 +1325,15 @@ impl<D: QueryData, F: QueryFilter> QueryState<D, F> { | |||
| /// This does not validate that `world.id()` matches `self.world_id`. Calling this on a `world` | |||
| /// with a mismatched [`WorldId`] is unsound. | |||
| #[inline] | |||
| pub(crate) unsafe fn iter_many_unchecked_manual<'w, 's, EntityList: IntoIterator>( | |||
| pub(crate) unsafe fn iter_many_unchecked_manual<'w, 's, EntityList>( | |||
There was a problem hiding this comment.
Moved to the the where clause because it was getting formatted due to the length
janhohenheim
approved these changes
Sep 5, 2024
|
Nice change :) |
janhohenheim
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Make the bounds for these query methods less intimidating.
Continuation of #14107
My last pr was back in february 💀