Use Rust bundled lld for msvc target #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…necessary. Using the bundled lld (rust-lld) for Windows.
|
Awesome. I'll give this a quick test, but this is a very welcome simplification. A number of folks had issues with setting up lld. |
karroffel
added
A-Build-System
|
This works on my machine. Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Clinker=lld was overwriting linker="lld-link.exe"; having both is unnecessary.
Using the bundled lld (rust-lld) for Windows.
As outlined here, there are concerns for defaulting to lld on Linux/Unix that don't apply to Windows. On Windows it's expected that the linker is called directly, which is why linker can be assigned to lld for Windows but must be assigned to clang/gcc on Linux.
Blocking issues related to defaulting to lld on Windows can be found here. I don't think any of those issues apply especially to the bundled rust-lld aside from it may get patches later (or sooner) than llvm packages elsewhere.