Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't debug SystemId's entity field twice #14499

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Don't debug SystemId's entity field twice #14499

merged 1 commit into from
Jul 27, 2024

Conversation

SkiFire13
Copy link
Contributor

@SkiFire13 SkiFire13 commented Jul 27, 2024 •
edited
Loading

Objective

Solution

  • Only include it once

Alternatively, this could be changed to match the struct representation of SystemId, thus instructing the formatter to print a named struct and including the PhantomData field.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jul 27, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 27, 2024
Merged via the queue into bevyengine:main with commit bc80b95 Jul 27, 2024
30 checks passed
@SkiFire13 SkiFire13 deleted the systemid-fix-debug branch July 27, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SkiFire13 @alice-i-cecile