Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing paths in ECS SystemParam derive macro #1434

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

woubuc
Copy link
Contributor

@woubuc woubuc commented Feb 11, 2021

The SystemParam derive macro had some missing path scopes, which lead to SystemParam not correctly getting resolved in some situations.

@cart
Copy link
Member

cart commented Feb 11, 2021

Looks good to me. Nice catch!

@cart
Copy link
Member

cart commented Feb 11, 2021

/rebase

@cart cart merged commit b39df9a into bevyengine:master Feb 11, 2021
@TheRawMeatball TheRawMeatball mentioned this pull request Feb 16, 2021
bors bot pushed a commit that referenced this pull request Aug 10, 2021
This is an updated version of #1434 PR. I've encountered this macro problem while trying to use @woubuc's bevy-event-set crate.

Co-authored-by: Piotr Balcer <[email protected]>
bors bot pushed a commit that referenced this pull request Aug 11, 2021
This is an updated version of #1434 PR. I've encountered this macro problem while trying to use @woubuc's bevy-event-set crate.

Co-authored-by: Piotr Balcer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants