-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track source location in change detection #14034
base: main
Are you sure you want to change the base?
Conversation
d3242ff
to
9ac216d
Compare
|
I really like this feature and think it'll be very useful, but I'll second the request for putting it behind an off-by-default feature flag. |
Yup, I assumed as much. I was hoping to get a read on whether this is even an acceptable approach to take for the feature. Before going down the path of adding feature flags. |
Is there a reason you're de referencing the static reference you get from |
Furthermore, why do you use |
The answer to most questions is probably going to be "because this is a proof of concept". 😄
For 2, it seems like it should be possible to get information from |
Is it possible to find the |
I would like this, one day :) Probably core + alloc, but still! Not a priority, but might as well do it when there's no cost to it. |
Objective
Solution
Testing
component_change_detection
example now shows where the component was mutated:Changelog
Migration Guide
caller
field to many internal ECS functions used with change detection. Use Location::caller() to provide the source of the function call.