Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow more configuration for showcase from the CLI #13217

Merged
merged 4 commits into from
Jul 22, 2024
Merged

allow more configuration for showcase from the CLI #13217

merged 4 commits into from
Jul 22, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented May 3, 2024

Objective

  • The default values hard coded in the showcase script may not make sense depending on your hardware

Solution

  • Let them be customised from the CLI

@mockersf mockersf added the A-Dev-Tools Tools used to debug Bevy applications. label May 3, 2024
@mockersf mockersf closed this May 17, 2024
@mockersf mockersf deleted the showcase-configurability branch May 17, 2024 21:15
@mockersf mockersf restored the showcase-configurability branch May 17, 2024 21:15
@mockersf mockersf reopened this May 17, 2024
@BD103 BD103 added C-Feature A new feature, making something new possible S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 26, 2024
BD103
BD103 reviewed May 26, 2024
View reviewed changes
tools/example-showcase/src/main.rs Outdated Show resolved Hide resolved
tools/example-showcase/src/main.rs Show resolved Hide resolved
tools/example-showcase/src/main.rs Show resolved Hide resolved
tools/example-showcase/src/main.rs Show resolved Hide resolved
tools/example-showcase/src/main.rs Show resolved Hide resolved
tools/example-showcase/src/main.rs Show resolved Hide resolved
@IceSentry IceSentry self-requested a review July 17, 2024 19:27
@rparrett rparrett self-requested a review July 17, 2024 19:28
rparrett
rparrett approved these changes Jul 19, 2024
View reviewed changes
tools/example-showcase/src/main.rs Outdated Show resolved Hide resolved
@BD103 BD103 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 19, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 22, 2024
Merged via the queue into bevyengine:main with commit 0d1f358 Jul 22, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rparrett rparrett rparrett approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@BD103 BD103 BD103 approved these changes

@IceSentry IceSentry Awaiting requested review from IceSentry

Assignees
No one assigned
Labels
A-Dev-Tools Tools used to debug Bevy applications. C-Feature A new feature, making something new possible S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @rparrett @alice-i-cecile @BD103