Use Cow<'static, str> in Name #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart
reviewed
Jan 25, 2021
|
|
||
| fn apply(&mut self, value: &dyn Reflect) { | ||
| let value = value.any(); | ||
| if let Some(value) = value.downcast_ref::<Self>() { |
There was a problem hiding this comment.
We've removed type coercion from the reflect api (ex: we used to coerce all ints to the appropriate precision, but now we dont). I think for simplicity / consistency we should only accept Cow<'static, str> here unless absolutely necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading #1283 I thought to myself, "yay, a chance to try actually using
Cow<...>!" ... and then found thatCowisn'tReflectyet...so I gave implementing that trait a shot too.I cargo-culted more of this than I'm comfortable with, especially with the
Reflectstuff, so please take a close look at this. I'm looking forward to learning what I did wrong. 😉 I originally tried to useimpl_reflect_value!, but I couldn't untangle the'staticlifetime errors caused by it, so I went for the manual implementation.