Add into_ methods for EntityMut and EntityWorldMut that consume self. #12419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
jkb0o
force-pushed
the
pr/entity_world_mut_into_mut
branch
from
ada5f60
to
0a90863
Compare
This comment was marked as resolved.
This comment was marked as resolved.
jkb0o
force-pushed
the
pr/entity_world_mut_into_mut
branch
from
0a90863
to
6064efe
Compare
jkb0o
changed the title
The into_ methods on the EntityMut/EntityWorldMut consumes self and returns component access with the world lifetime unlike the get_ methods that takes ref and retuns component acess with &'a self lifetime. Methods implemented: - EntityMut::into_borrow - EntityMut::into_ref - EntityMut::into_mut - EntityMut::into_by_id - EntityMut::into_mut_by_id - EntityWorldMut::into_borrow - EntityWorldMut::into_ref - EntityWorldMut::into_mut - EntityWorldMut::into_by_id - EntityWorldMut::into_mut_by_id
jkb0o
force-pushed
the
pr/entity_world_mut_into_mut
branch
from
6064efe
to
7ca36fa
Compare
|
Looks like you changed the methods name, can you change the title to reflect those changes? |
jkb0o
changed the title
jkb0o
changed the title
james7132
added
A-ECS
james7132
approved these changes
Mar 11, 2024
pablo-lua
approved these changes
Mar 11, 2024
james7132
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Provide component access to
&'w T,Ref<'w, T>,Mut<'w, T>,Ptr<'w>andMutUntyped<'w>fromEntityMut<'w>/EntityWorldMut<'w>with the world'wlifetime instead of'_.Fixes #12417
Solution
Add
into_prefixed methods forEntityMut<'w>/EntityWorldMut<'w>that consumeselfand returns component access with the world'wlifetime unlike theget_prefixed methods that takes&'a selfand returns component access with'alifetime.Methods implemented: