Disentangle bevy_utils/bevy_core's reexported dependencies #12313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
added
C-Dependencies
alice-i-cecile
approved these changes
Mar 5, 2024
alice-i-cecile
added
the
C-Code-Quality
|
Good stuff. I'd like to look into workspace-level dependencies at some point too. Looks like there's more toml formatting to do. |
NthTensor
approved these changes
Mar 6, 2024
NiseVoid
approved these changes
Mar 6, 2024
| @@ -10,12 +10,13 @@ keywords = ["bevy"] | |||
| readme = "README.md" | |||
|
|
|||
| [features] | |||
| default = [] | |||
| default = ["smallvec"] | |||
There was a problem hiding this comment.
Having just this feature in default feels wrong 🤔
There was a problem hiding this comment.
This makes it a non-breaking change because previously it wasn't optional.
alice-i-cecile
added
the
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
CI failures are real, unsurprisingly. James, feel free to merge once you can get things building without default features. |
spectria-limina
pushed a commit
to spectria-limina/bevy
that referenced
this pull request
Mar 9, 2024
…e#12313) # Objective Make bevy_utils less of a compilation bottleneck. Tackle bevyengine#11478. ## Solution * Move all of the directly reexported dependencies and move them to where they're actually used. * Remove the UUID utilities that have gone unused since `TypePath` took over for `TypeUuid`. * There was also a extraneous bytemuck dependency on `bevy_core` that has not been used for a long time (since `encase` became the primary way to prepare GPU buffers). * Remove the `all_tuples` macro reexport from bevy_ecs since it's accessible from `bevy_utils`. --- ## Changelog Removed: Many of the reexports from bevy_utils (petgraph, uuid, nonmax, smallvec, and thiserror). Removed: bevy_core's reexports of bytemuck. ## Migration Guide bevy_utils' reexports of petgraph, uuid, nonmax, smallvec, and thiserror have been removed. bevy_core' reexports of bytemuck's types has been removed. Add them as dependencies in your own crate instead.
zhaop
added a commit
to zhaop/transform-gizmo
that referenced
this pull request
Jun 24, 2024
Addresses Bevy [12313](bevyengine/bevy#12313)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Make bevy_utils less of a compilation bottleneck. Tackle #11478.
Solution
TypePathtook over forTypeUuid.bevy_corethat has not been used for a long time (sinceencasebecame the primary way to prepare GPU buffers).all_tuplesmacro reexport from bevy_ecs since it's accessible frombevy_utils.Changelog
Removed: Many of the reexports from bevy_utils (petgraph, uuid, nonmax, smallvec, and thiserror).
Removed: bevy_core's reexports of bytemuck.
Migration Guide
bevy_utils' reexports of petgraph, uuid, nonmax, smallvec, and thiserror have been removed.
bevy_core' reexports of bytemuck's types has been removed.
Add them as dependencies in your own crate instead.